Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a hawkular client for partial endpoints #13814

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Create a hawkular client for partial endpoints #13814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions app/models/manageiq/providers/hawkular/datawarehouse_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,38 @@ def self.verify_ssl_mode
end

# Hawkular Client
def self.raw_connect(hostname, port, token, alerts = false)
client = alerts ? ::Hawkular::Alerts::AlertsClient : ::Hawkular::Metrics::Client
client.new(
def self.raw_connect(hostname, port, token, type = :alerts)
klass = case type
when :metrics
::Hawkular::Metrics::Client
when :alerts
::Hawkular::Alerts::AlertsClient
else
raise ArgumentError, "Client not found for #{type}"
end
klass.new(
URI::HTTPS.build(:host => hostname, :port => port.to_i).to_s,
{ :token => token },
{ :tenant => '_system', :verify_ssl => verify_ssl_mode }
)
end

def connect(options = {})
@client ||= self.class.raw_connect(hostname,
port,
authentication_token('default'),
options[:alerts])
@clients ||= {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the @client being defined then? Is it utilized anywhere else in the class?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they use the returned variable and only use @client and the new @clients to save the connection for future calls.
Is that right @moolitayer ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is a memoization technique @client is defined only here. On the first call it will create and return the relevant client and from that point on it will return the stored value.

@clients[options[:type]] ||= self.class.raw_connect(
hostname,
port,
authentication_token('default'),
options[:type]
)
end

def alerts_client
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are already doing that, why not do it with metaprogramming? That way you don't need to add another method in case another client is added.

CLIENT_CLASSES.keys.each do |type|
  define_method("#{type}_client") do
    connect(:type => type)
  end
end

connect(:type => :alerts)
end

def metrics_client
connect(:type => :metrics)
end

def supports_port?
Expand Down