Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding datawarehouse provider with a port other than 80 #13840

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Allow adding datawarehouse provider with a port other than 80 #13840

merged 1 commit into from
Feb 13, 2017

Conversation

dkorn
Copy link
Contributor

@dkorn dkorn commented Feb 9, 2017 •
edited by miq-bot
Loading

When adding a datawarehouse provider, port 80 is being used for the "default" role endpoint, even if a different port was specified.

@dkorn
Allow to add datawarehouse provider with a port other than 80
4b2bb69 
When adding a datawarehouse provider, port 80 is being used for
the "default" role endpoint, even if a different port was specified.
@dkorn dkorn changed the title Allow to add datawarehouse provider with a port other than 80 Allow adding datawarehouse provider with a port other than 80 Feb 9, 2017
@dkorn
Copy link
Contributor Author

dkorn commented Feb 9, 2017

@miq-bot add_label bug, providers/hawkular

@dkorn
Copy link
Contributor Author

dkorn commented Feb 9, 2017

@moolitayer @simon3z @zgalor please review

@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2017

Checked commit dkorn@4b2bb69 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@zgalor
Copy link
Contributor

zgalor commented Feb 9, 2017

👍 LGTM. Also tested locally

@simon3z
Copy link
Contributor

simon3z commented Feb 9, 2017

LGTM 👍
cc @blomquisg @chessbyte

@miq-bot assign @blomquisg

@dkorn
Copy link
Contributor Author

dkorn commented Feb 13, 2017

@blomquisg any chance you'll have time take a look today?

@bronaghs
Copy link

@miq-bot assign @agrare

@miq-bot miq-bot assigned agrare and unassigned blomquisg Feb 13, 2017
@agrare
Copy link
Member

agrare commented Feb 13, 2017

LGTM

@agrare agrare merged commit e14009d into ManageIQ:master Feb 13, 2017
@agrare agrare added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 13, 2017
@agrare agrare added the euwe/no label Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
bug providers/middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dkorn @miq-bot @zgalor @simon3z @bronaghs @agrare @blomquisg @chessbyte