Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: bring currency symbols back to chargeback reports #13861

Merged

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Feb 10, 2017

Addressing regression introduced in e6b02b5

The yaml file contains symbolized keys, when accessing format values, we
need to use symbols as well.

Not in euwe. Just in master.

@miq-bot add_label bug, reporting, chargeback, euwe/no
@miq-bot assign @gtanzillo

Addressing regression introduced in e6b02b5

The yaml file contains symbolized keys, when accessing format values, we
need to use symbols as well.
@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2017

Checked commit isimluk@d84d9c2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 10, 2017
@gtanzillo gtanzillo merged commit 86fd694 into ManageIQ:master Feb 10, 2017
@isimluk isimluk deleted the chargeback-regression-bring-currencies-back branch February 11, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants