Warn if OpenSCAP binary not available #13878
Conversation
|
@cben Take a look, not sure this is the most elegant way |
|
Checked commit moolitayer@d6f45d5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks 👍 Is "binary missing" correct wording? Does the execute a binary, of do FFI calls to a library? |
|
Specifically, require openscap was failing with libopenscap.8.so or something like that. |
|
It is a dynamically linked library called from an ffi wrapper (the gem). The propose of this PR is when customers encounter the problem on a new environment that has it's own dependency management (like we recently had with podified ManageIQ as it manages dependencies differently then the appliance) they will be able to provide a meaningful error report. We could log the error in the require time but my first priority is to have the error with the other job logging since that's usually what we get. |
|
BTW @cben we could have potentially raised the error and get it in the log but then the termination is less clean that way and I try to avoid that. In those cases the job keeps thinking it is active and is timed out by the scheduler so we get another error in the log (so sometimes customers miss the important one) and we get the failure not then it happends |
| @@ -157,6 +157,10 @@ def analyze | |||
| end | |||
|
|
|||
| def collect_compliance_data(image) | |||
| unless OpenscapResult.openscap_available? | |||
| _log.warn "OpenSCAP Binary missing, skipping scan" | |||
There was a problem hiding this comment.
So consider s/Binary/Library/here.
|
LGTM. |
|
@simon3z please review, not a priority |
|
@roliveri Can you please review this change? |
|
@moolitayer Should this be back ported anywhere? |
In the appliance and podified ManageIQ the OpenSCAP Binary is installed. I added some warning at require failures so that customers that encounter the problem on a new environment that has it's own dependency management (like we recently had with podified ManageIQ) will be able to easily report what is wrong.
See See ManageIQ/guides#189