Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spice-html5-bower to 1.6.3, fixing an extra GET .../null request #13889

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Update spice-html5-bower to 1.6.3, fixing an extra GET .../null request #13889

merged 1 commit into from
Feb 15, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Feb 13, 2017

Updating to newer version of spice-html5-bower.

(Yes, the jump from 0.1.6 to 1.6.3 is intentional, 0.1.6 was actually 0.1.6.1 upstream (spice-html5, not spice-html5-bower), but since bower nor npm support 4-digit versions, I dropped the leading 0.)

https://bugzilla.redhat.com/show_bug.cgi?id=1421086
EUWE: https://bugzilla.redhat.com/show_bug.cgi?id=1424255

@himdel
Copy link
Contributor Author

himdel commented Feb 13, 2017

@miq-bot add_label bug, ui

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2017

Checked commit https://github.com/himdel/manageiq/commit/c2bdc50522e36bd216e4249caf9ce99d0f9d7dda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@martinpovolny
Copy link
Member

@himdel : euwe?

@martinpovolny martinpovolny merged commit 964ba23 into ManageIQ:master Feb 15, 2017
@martinpovolny martinpovolny added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 15, 2017
@himdel himdel deleted the update-spice branch February 15, 2017 15:35
@himdel
Copy link
Contributor Author

himdel commented Feb 15, 2017

@miq-bot add_label euwe/yes

simaishi pushed a commit that referenced this pull request Mar 3, 2017
Update spice-html5-bower to 1.6.3, fixing an extra GET .../null request
(cherry picked from commit 964ba23)

https://bugzilla.redhat.com/show_bug.cgi?id=1424255
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport details:

$ git log -1
commit 998d390804c26aea4c35a8da9a017e3007718c3b
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Feb 15 15:57:03 2017 +0100

    Merge pull request #13889 from himdel/update-spice
    
    Update spice-html5-bower to 1.6.3, fixing an extra GET .../null request
    (cherry picked from commit 964ba2319b51f20e57e29fc1e333fed3d2ca09ed)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1424255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants