Create catalog item after job templates are created #13893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
force-pushed
the
playbook_service_template
branch
from
0f1b7ee
to
9b74a39
Compare
bdunne
requested changes
Feb 13, 2017
| service_name = options[:name] | ||
| description = options[:description] | ||
| config_info = validate_config_info(options) | ||
|
|
||
| enhanced_config = config_info.deep_merge(create_job_templates(service_name, description, config_info, auth_user)) |
syncrou
reviewed
Feb 15, 2017
| def self.create_catalog_item(options, _auth_user) | ||
| options = options.merge(:service_type => 'atomic', :prov_type => 'generic_ansible_playbook') | ||
| def self.create_catalog_item(options, auth_user) | ||
| options = options.deep_dup.merge(:service_type => 'atomic', :prov_type => 'generic_ansible_playbook') |
There was a problem hiding this comment.
@bzwei - What changed that would require the call to deep_dup vs. just merge before?
There was a problem hiding this comment.
yes. I don't need deep_dup here. I need to make sure input options are not modified
|
This pull request is not mergeable. Please rebase and repush. |
This is to continue the work to create a catalog item after the initial work
bzwei
force-pushed
the
playbook_service_template
branch
from
9b74a39
to
472e70e
Compare
|
Checked commit bzwei@472e70e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Feb 15, 2017
|
👍 Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to continue the work to create a catalog item after the initial work
@syncrou @gmcculloug please review