Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eager_load for extra_resources #13904

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Feb 14, 2017

These associations are touched in ConsumptionWithoutRollup and RateCache, they can be loaded in one query

@miq-bot add_label chargeback, performance

There are some stats rows_by_class: and :total_queries:,
after: left - before: right

screen shot 2017-02-14 at 10 39 32

cc @isimluk
@miq-bot assign @gtanzillo

we are touching associations in ConsumptionWithoutRollup
or in RatesChache#parents_determining_rate
@miq-bot
Copy link
Member

miq-bot commented Feb 14, 2017

Checked commit lpichler@f847d82 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@gtanzillo gtanzillo added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 14, 2017
@gtanzillo gtanzillo merged commit 8ca69c6 into ManageIQ:master Feb 14, 2017
@lpichler lpichler deleted the use_eager_load_for_extra_resources branch February 14, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants