Add the Automation Manager submenu key to the permission yaml file #13931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
add_automation_manager_sub_menu_to_perm_yml
branch
from
24ad896
to
f175b0e
Compare
|
@miq-bot add_label ui, bug |
|
/cc @h-kataria |
|
Checked commits lgalis/manageiq@f175b0e~...9172f98 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
reviewed
Feb 16, 2017
app/models/miq_action.rb
Outdated
| @@ -20,7 +20,8 @@ class MiqAction < ApplicationRecord | |||
| "set_custom_attribute" => "Set a Custom Attribute in vCenter", | |||
| "inherit_parent_tags" => "Inherit Parent Tags", | |||
| "remove_tags" => "Remove Tags", | |||
| "delete_snapshots_by_age" => "Delete Snapshots by Age" | |||
| "delete_snapshots_by_age" => "Delete Snapshots by Age", | |||
There was a problem hiding this comment.
@lgalis this change doesn't look related to addition of key to permissions file.
There was a problem hiding this comment.
yes - just noticed I had pushed this as well- taking it off now.
lgalis
force-pushed
the
add_automation_manager_sub_menu_to_perm_yml
branch
from
9172f98
to
f175b0e
Compare
|
|
|
@h-kataria @lgalis Also, once this is merged, don't forget the downstream change as well. |
|
at = Ansible Tower |
|
Just adding in my general displeasure in that there should never be tab names that are provider specific. Even so, that bridge has already been crossed 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Automation Manager submenu key to the permission yaml file
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1422533
Steps for Testing/QA
copy the config/permissions.tmpl.yml to config/permissions.yml
Same as #13819 - this time for the Ansible Tower sub-menu