Create a provision request for a service template

[mkanoor]

Model method to submit a provision request from a service template.

https://www.pivotaltracker.com/n/projects/1937537/stories/140055813

This method is also accessible from Automate method e.g

st = $evm.root["service_template"]
req=$evm.create_service_provision_request(st, {})

[gmcculloug]

@mkanoor If we want to allow the API to call this it should be broken up into two methods. One to be called from the API that returns the workflow to match what the current code does: lib/services/api/service_template_workflow.rb#L7

And another which can be called when we need to create and submit the workflow. This would support the two use cases from the API as well as what we need for control actions and automate.

Current API callers:

manageiq/app/controllers/api/subcollections/service_templates.rb

Line 32 in bc7fd6b

workflow = ServiceTemplateWorkflow.create(service_template, data || {})

manageiq/app/controllers/api/service_orders_controller.rb

Line 84 in bc7fd6b

ServiceTemplateWorkflow.create(service_template, service_request)

[gmcculloug]

LGTM @abellotti Please review the recent changes.

[abellotti]

this might fail if method is called as provision_workflow(userid, nil)
maybe default options to nil, then have a separate options ||= {}

[mkanoor]

@abellotti @gmcculloug
Please review.
I have changed to pass in user object instead of userid.
and default value for options is nil

[abellotti]

LGTM!! @mkanoor thanks for the update.

[mkanoor]

Fails with the
app/models/miq_request_workflow.rb:738:in set_request_values': undefined method current_group' for nil:NilClass (NoMethodError)

[miq-bot]

Checked commits mkanoor/manageiq@b4cf882~...06fdddd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

[mkanoor]

@gmcculloug
Please review, the travis failure is unrelated to my changes

[gmcculloug]

👍 Once we tests green.