Add registered_provider_plugins to Vmdb::Plugins #13983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for querying which providers are registered via plugins it also provides a helper method to query for provider names of all registered providers
bdunne
requested changes
Feb 20, 2017
lib/vmdb/plugins.rb
Outdated
| def register_automate_domains(engine) | ||
| Dir.glob(engine.root.join("content", "automate", "*")).each do |domain_directory| | ||
| @registered_automate_domains << AutomateDomain.new(domain_directory) | ||
| def provider_plugin_names |
There was a problem hiding this comment.
We usually implement something like this as:
def provider_plugin_names(refresh = false)
@provider_plugin_names = nil if refresh
@provider_plugin_names ||= .....
end
lib/vmdb/plugins.rb
Outdated
| def register_provider_plugin(engine) | ||
| if engine.class.name.start_with?("ManageIQ::Providers::") | ||
| @registered_provider_plugins << engine | ||
| @provider_plugins_names = nil |
There was a problem hiding this comment.
It feels strange to wipe this cache in this method. Based on the comment above, you could instead call provider_plugin_names(true)
lib/vmdb/plugins.rb
Outdated
| @registered_automate_domains << AutomateDomain.new(domain_directory) | ||
| def provider_plugin_names | ||
| @provider_plugins_names ||= registered_provider_plugins.collect do |plugin| | ||
| ManageIQ::Providers::Inflector.provider_name(plugin).downcase.to_sym |
There was a problem hiding this comment.
Should this be underscore rather than downcase to deal with things like AnsibleTower in the future?
|
@bdunne addressed your feedback - thanks for catching the |
|
Checked commits durandom/manageiq@edc86e2~...9e6d72f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows for querying which providers are registered via plugins.
it also provides a helper method to query for provider names of all registered providers
extracted from #13942
@miq-bot add_labels pluggable providers, enhancement
@miq-bot assign @bdunne