Add :event_catcher_openstack_service setting #13985
Conversation
Adding setting which allows switch Openstack Event provider service. Possible values: * "ceilometer" * "panko" * "auto" (and any other string means auto)
|
Checked commit aufi@abe500c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 This turned out to be necessary for metrics, so a parallel setting for events makes a lot of sense! |
|
@blomquisg Hi, may I ask for review (to be able to continue on depending PR)? Thanks! |
| @@ -1283,6 +1283,7 @@ | |||
| :poll: 10.seconds | |||
| :event_catcher_swift: | |||
| :poll: 10.seconds | |||
| :event_catcher_openstack_service: "auto" | |||
There was a problem hiding this comment.
Is there anyway this can be bumped up to the :event_catcher_openstack section?
I'd rather have it there, than add another new section for OpenStack. Thoughts?
There was a problem hiding this comment.
:event_catcher_openstack section is for Cloud provider (the name is misleading here, propably for historical reasons).
We need this option to affect all Openstack-like providers (cloud, infra, network, ...) so I'd prefer keep it outside the Cloud provider related section.
There was a problem hiding this comment.
K, we'll just need to make sure this gets picked up when OSP is extracted to its own repo /cc @durandom
|
@miq-bot add_label euwe/yes |
|
This PR is required by ManageIQ/manageiq-gems-pending#57 |
…ce_setting Add :event_catcher_openstack_service setting (cherry picked from commit 5745d62) https://bugzilla.redhat.com/show_bug.cgi?id=1436340
|
Euwe backport details: |
Adding setting which allows switch Openstack Event provider service into settings.yml.
The switch is needed because OSP telemetry services (like Event providing service) can be disabled, installed on older OSP versions or manually changed. These cases might not be handled by automatic selection of Events service well (proven on Metric telemetry services).
This setting will be used by ManageIQ/manageiq-gems-pending#57
Possible values:
Links