Collect more attributes for Ansible Tower job #14076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
force-pushed
the
ansible_job_enhance
branch
from
be8c5b8
to
b059b3d
Compare
|
@bdunne Please review |
bdunne
reviewed
Feb 27, 2017
|
|
||
| if parameters.empty? | ||
| self.parameters = | ||
| raw_job.extra_vars_hash.collect do |para_key, para_val| |
There was a problem hiding this comment.
I think this should be on the previous line to prevent the awkward indentation.
| @@ -119,4 +120,11 @@ def inventory_name(action) | |||
| def use_default_inventory?(hosts) | |||
| hosts.blank? || hosts == 'localhost' | |||
| end | |||
|
|
|||
| # update job attributes only available to playbook provisioning | |||
| def update_job_for_playbook(action, job, hosts) | |||
There was a problem hiding this comment.
Does this need a hosts = nil or are you expecting someone to pass nil as the last arg?
There was a problem hiding this comment.
This is a private method used internal only, but hosts might be nil if it is never set anywhere.
bzwei
force-pushed
the
ansible_job_enhance
branch
from
b059b3d
to
303d3da
Compare
bdunne
approved these changes
Feb 28, 2017
|
@bzwei Please review test failures. |
bzwei
force-pushed
the
ansible_job_enhance
branch
from
303d3da
to
e807f8e
Compare
|
Checked commit bzwei@e807f8e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attributes include start_time, finish_time, verbosity, hosts, and configuration_script_base_id
https://www.pivotaltracker.com/story/show/140529219