Fix ordering by VMs in NetworkManagers list #14092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ordering by VMs in NetworkManagers list Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1383307
Ladas
force-pushed
the
fix_ordering_by_vms_in_network_managers_list
branch
from
5b86dff
to
5c835d4
Compare
|
before: after:
|
kbrock
reviewed
Feb 28, 2017
| @@ -25,6 +25,21 @@ class << model_name | |||
| has_many :load_balancer_health_checks, :foreign_key => :ems_id, :dependent => :destroy | |||
| has_many :load_balancer_health_check_members, :through => :load_balancer_health_checks | |||
|
|
|||
| # Generates ORDER BY ((SELECT COUNT(*) FROM "vms" WHERE "ext_management_systems"."parent_ems_id" = "vms"."ems_id")) | |||
There was a problem hiding this comment.
a. is it possible to define this higher up in the inheritance chain?
rewrite:
# Uses "ext_management_systems"."parent_ems_id" instead of "ext_management_systems"."id"
#
# ORDER BY ((
# SELECT COUNT(*)
# FROM "vms"
# WHERE "ext_management_systems"."parent_ems_id" = "vms"."ems_id"
# ))There was a problem hiding this comment.
hm I think it need to be here, it's specific to NetworkManager (or StorageManager). So any manager that has Vms through :parent_manager
Reformat the comment nicely
|
Checked commits Ladas/manageiq@5c835d4~...e2c1e8a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/network_manager.rb
|
|
kicking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ordering by VMs in NetworkManagers list
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1383307