[Api] Improve error handling on destroy action #14098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way nobody runs the delete without the rbac check.
ActiveRecord.destroy selects the resource to memory to run all the callbacks and validations anyway.
Sometimes validations disallow user to delete a resource. Let's make him/her conscious about the reasons.
|
Checked commits isimluk/manageiq@18a0cd0~...d3d5dcd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Hi @isimluk I think this is good. Why the euwe/yes flag though ? |
|
I have noticed this issue when working on https://bugzilla.redhat.com/show_bug.cgi?id=1414881 I expect the guy behind the bug may happen to notice as well, so I put here euwe/yes. It can be euwe/no as well. |
|
saw your fix for that on #14097, nice !! yes, would prefer this PR here separate from the Bug, and thus euwe/no. Thanks. |
|
Thanks @isimluk for this enhancement. LGTM!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements of the generic resource_delete action
@miq-bot add_label api, enhancement, euwe/yes
@miq-bot assign @abellotti