Sort files to require for coverage reports

[lpichler]

Dir.glob don't guarantee the order of the files it returns
For example we have model in
app/model/rss_feed.rb and his extension in
app/model/rss_feed/import_export.rb - there is class
defined without inheriting from ApplicationRecord
so when class from import_export.rb is loaded first
is it loaded as RssFeed < Object and when
after this is app/model/rss_feed.rb loaded
it is causing error(this warning is suppressed by
silence_warnings in coverage_helper):

TypeError: superclass mismatch for class RssFeed

and then RssFeed < ApplicationRecord is not loaded

Sorting Dir.glob guarantee order so that
files will be first then subdirectories,..
() because '.'.ord < '/'.ord
(sort is also used in eager_load!
https://github.com/rails/rails/blob/master/railties/lib/rails/engine.rb#L475)

this sporadic failure can be seen here: https://travis-ci.org/ManageIQ/manageiq/jobs/206552109
(there are some my debug messages)

This PR is blocking #14041

thanks @isimluk for help!

cc @kbrock @jrafanie
@miq-bot assign @gtanzillo

@miq-bot add_label bug/sporadic test failure, test

[miq-bot]

Checked commit lpichler@7b3d7b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

[isimluk]

👍 Thanks for digging down for the reason behind the sporadic test failure!

[jrafanie]

@lpichler @isimluk Wow, nice find!

Am I correct in assuming we'll be renaming or namespacing the RssFeed from the import/export in a future PR? This PR will fix that issue but we can't have two RssFeed classes.

[isimluk]

Am I correct in assuming we'll be renaming or namespacing the RssFeed from the import/export in a future PR? This PR will fix that issue but we can't have two RssFeed classes.

Not necessarily, no. We have this patter in multiple places and it is not at all harmful.

There are two modes when ruby parses class.

• first creation
• re-opening and adding stuff

Note that the following re-opening is fine:

class RssFeed < Application Record
 ...
end
class RssFeed
 ... something else
end

while the following will result in an exception:

class RssFeed
 ...
end
class RssFeed < ApplicationRecord
.. something else
end

So, ruby does the check for us. The problem with this code was that it silences_warnings.