Update catalog item without config_options #14147
Conversation
|
@jntullo https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template.rb#L429 the validation on the |
| @@ -426,7 +427,11 @@ def build_resource_action(ae_endpoint, action) | |||
| end | |||
|
|
|||
| def validate_update_config_info(options) | |||
| raise _('service_type and prov_type cannot be changed') if options[:service_type] || options[:prov_type] | |||
| if options[:service_type] && options[:service_type] != service_type | |||
There was a problem hiding this comment.
should be two independent if...end blocks
| @@ -87,6 +87,27 @@ | |||
| expect(updated.resource_actions.pluck(:action)).to match_array(%w(Provision Reconfigure)) | |||
| end | |||
|
|
|||
| it 'does not allow service_type to be changed' do | |||
There was a problem hiding this comment.
We may not need to repeat tests that are already covered in base class.
There was a problem hiding this comment.
@bzwei ok - just thought it would be a good idea to ensure that it includes the super class method call
|
Checked commits jntullo/manageiq@a8947bc~...4aafba6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @gmcculloug |
This will update the catalog item without the need for
config_options. Will update #14068 based off of this.@miq-bot add_label enhancement, services
@miq-bot assign @bzwei
cc: @abellotti