Set 'https' as the default protocol when using oVirt SDK #14157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the oVirt provider so that it uses 'https' by default as the protocol when using the oVirt SDK to talk to the oVirt engine. Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
|
@borod108 @pkliczewski please review. |
pkliczewski
approved these changes
Mar 3, 2017
|
Checked commit https://github.com/jhernand/manageiq/commit/536def0c75fad455835691c0ed0605cc8090e91f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@durandom please review. |
|
@oourfali the change in this PR looks trivial. Please give your 👍 so we can merge. |
|
I see @pkliczewski approved, so we can proceed with this one. |
|
@durandom It used to be the default, till it was lost with this recent commit: 1ad9eb7#diff-d6125c21d43685840429020f8c5a57aaL271 This only restores it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the oVirt provider so that it uses 'https' by default
as the protocol when using the oVirt SDK to talk to the oVirt engine.