Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration_script_source aka project to create through Tower API #14173

Merged
merged 2 commits into from
Mar 13, 2017
Merged

configuration_script_source aka project to create through Tower API #14173

merged 2 commits into from
Mar 13, 2017

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Mar 3, 2017

@miq-bot add_labels wip, providers/ansible_tower, enhancement

This is depending on #14027

@miq-bot miq-bot changed the title configuration_script_source aka project to create through Tower API [WIP] configuration_script_source aka project to create through Tower API Mar 3, 2017
@miq-bot miq-bot changed the title [WIP] configuration_script_source aka project to create through Tower API configuration_script_source aka project to create through Tower API Mar 3, 2017
@miq-bot miq-bot removed the wip label Mar 3, 2017
@jameswnl jameswnl changed the title configuration_script_source aka project to create through Tower API [WIP] configuration_script_source aka project to create through Tower API Mar 3, 2017
@chessbyte chessbyte added the wip label Mar 3, 2017
@jameswnl jameswnl force-pushed the api-create-project branch 3 times, most recently from 8910add to 936e012 Compare March 3, 2017 22:00
@jntullo jntullo mentioned this pull request Mar 7, 2017
Merged
jameswnl
jameswnl commented Mar 9, 2017
View reviewed changes
...ls/manageiq/providers/ansible_tower/shared/automation_manager/configuration_script_source.rb Outdated

# Get the record in our database
# TODO: This needs to be targeted refresh so it doesn't take too long
EmsRefresh.queue_refresh(manager, nil, true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use the new EmsRefresh.queue_refresh_task once #14027 is in

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2017

Checked commits jameswnl/manageiq@c15b9c8~...4249bc8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 3 offenses detected

spec/models/manageiq/providers/ansible_tower/automation_manager/configuration_script_source_spec.rb

  • ❗ - Line 23, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 24, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 25, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@jameswnl
Copy link
Contributor Author

@miq-bot remove_label wip

@jameswnl jameswnl changed the title [WIP] configuration_script_source aka project to create through Tower API configuration_script_source aka project to create through Tower API Mar 10, 2017
@miq-bot miq-bot removed the wip label Mar 10, 2017
@blomquisg blomquisg merged commit 3371b89 into ManageIQ:master Mar 13, 2017
@chessbyte chessbyte modified the milestones: Sprint 55 Ending Feb 27, 2017, Sprint 56 Ending Mar 13, 2017 Mar 17, 2017
@jameswnl jameswnl deleted the api-create-project branch March 23, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jameswnl @miq-bot @blomquisg @Fryguy @chessbyte