Add ae service model for S3 CloudObjectStoreObject #14189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
|
Checked commit xlab-si@1ae2578 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @blomquisg |
durandom
approved these changes
Mar 6, 2017
There was a problem hiding this comment.
👍
unfortunately this is a 🐔 🥚 PR
@blomquisg @Ladas @gmcculloug any idea how we can make this kind of PRs mergable without one Repo breaking the other?
|
@durandom I am working on changes to auto-generate empty service models for any missing classes. Until then I am not sure what we can do besides trying to coordinate when they get merged. |
|
I rekicked this after merging ManageIQ/manageiq-providers-amazon#152 Once this is green, I'll merge |
|
Green @blomquisg 😄 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
@miq-bot add_label enhancement,automate
@miq-bot assign @durandom