Refresh to pick up scm options for Tower Project #14220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswnl
force-pushed
the
project-refresh
branch
from
3ce8b90
to
4a4d0b0
Compare
|
Checked commit jameswnl@4a4d0b0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@durandom can you help take a look at this? |
durandom
reviewed
Mar 9, 2017
| @@ -48,6 +48,13 @@ def configuration_script_sources | |||
| inventory_object = persister.configuration_script_sources.find_or_build(project.id.to_s) | |||
| inventory_object.description = project.description | |||
| inventory_object.name = project.name | |||
| inventory_object.authentication = persister.credentials.lazy_find(project.credential_id.to_s) | |||
There was a problem hiding this comment.
cc @Ladas it would be nice if lazy_find would also work with non strings - maybe this is just a small tweak somehwere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/140875379
@miq-bot add_labels enhancement, providers/ansible_tower