-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Collections API for Cloud Volumes #14260
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1e6f2c9
Api for Cloud Volumes collection
AparnaKarve f84e814
spec to query cloud_volumes
AparnaKarve 050bc40
PR feedback -- Remove :subcollections and :subresource_actions
AparnaKarve e7fd6a6
spec for cloud volumes
AparnaKarve 0bbcd8a
bulk query spec for cloud volumes
AparnaKarve File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module Api | ||
class CloudVolumesController < BaseController | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# | ||
# REST API Request Tests - Cloud Volumes | ||
# | ||
# Regions primary collections: | ||
# /api/cloud_volumes | ||
# | ||
# Tests for: | ||
# GET /api/cloud_volumes/:id | ||
# | ||
|
||
describe "Cloud Volumes API" do | ||
it "forbids access to cloud volumes without an appropriate role" do | ||
api_basic_authorize | ||
|
||
run_get(cloud_volumes_url) | ||
|
||
expect(response).to have_http_status(:forbidden) | ||
end | ||
|
||
it "forbids access to a cloud volume resource without an appropriate role" do | ||
api_basic_authorize | ||
|
||
cloud_volume = FactoryGirl.create(:cloud_volume) | ||
|
||
run_get(cloud_volumes_url(cloud_volume.id)) | ||
|
||
expect(response).to have_http_status(:forbidden) | ||
end | ||
|
||
it "allows GETs of a cloud volume" do | ||
api_basic_authorize action_identifier(:cloud_volumes, :read, :resource_actions, :get) | ||
|
||
cloud_volume = FactoryGirl.create(:cloud_volume) | ||
|
||
run_get(cloud_volumes_url(cloud_volume.id)) | ||
|
||
expect(response).to have_http_status(:ok) | ||
expect(response.parsed_body).to include( | ||
"href" => a_string_matching(cloud_volumes_url(cloud_volume.id)), | ||
"id" => cloud_volume.id | ||
) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add the other test for bulk queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also probably need just the resource gets tests, look at spec/requests/api/regions_spec.rb and create a spec/requests/api/cloud_volumes_spec.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.