Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support operation create on CloudObjectStoreContainer #14269

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

miha-plesko
Copy link
Contributor

Support operation create on CloudObjectStoreContainer. Implementation for Amazon S3 depends on this.

@miq-bot add_label enhancement
@miq-bot assign @durandom

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good besides that comment

@miq-bot assign @agrare

@@ -16,4 +16,38 @@ class CloudObjectStoreContainer < ApplicationRecord

supports_not :delete, :reason => N_("Delete operation is not supported.")
supports_not :cloud_object_store_container_clear

#
# Static operations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove that comment?

@durandom
Copy link
Member

@miq-bot add_label providers

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2017

Checked commit xlab-si@a6665cf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

@agrare agrare assigned agrare and unassigned durandom Mar 13, 2017
@agrare agrare merged commit 5794cec into ManageIQ:master Mar 13, 2017
@agrare agrare added the euwe/no label Mar 13, 2017
@agrare agrare added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 13, 2017
@tadeboro tadeboro deleted the add_aws_bucket branch March 30, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants