Update to webmock 2.3.1+ and VCR 3.0.2+ #14270
Conversation
|
several hawkular UnhandledHTTPRequestError may be due to
No idea about all the UnusedHTTPInteractionError. The places the stack traces point to don't make sense to me - why does VCR think it should have used the whole cassette at those points? |
|
It's a major upgrade to webmock so I would expect that to be needed. We
need this version to avoid monkey patching webmock for Ruby 2.4 support.
…On Mar 14, 2017 7:15 PM, "Beni Cherniavsky-Paskin" ***@***.***> wrote:
several hawkular UnhandledHTTPRequestError may be due to ***@***.***
part:
- http://hservices.torii.gva.redhat.com/hawkular/inventory/status,
there are cassettes for
***@***.***
com/hawkular/inventory/status,
- http://127.0.0.1:8080/hawkular/inventory/status, there are cassettes
for
***@***.***:8080/hawkular/inventory/status (but in
different .yml)
No idea about all the UnusedHTTPInteractionError. The places the stack
traces point to don't make sense to me - why does VCR think it should have
used the whole cassette at those points?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14270 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABLi4gumJfrPXCCok1MKxe8pTqRCjh4ks5rlx-ugaJpZM4MZfZx>
.
|
jrafanie
force-pushed
the
ruby_24_upgrade_webmock_to_231
branch
from
a3e5dc4 to
dd5b776
Compare
|
This pull request is not mergeable. Please rebase and repush. |
jrafanie
force-pushed
the
ruby_24_upgrade_webmock_to_231
branch
from
dd5b776 to
9df0434
Compare
jrafanie
force-pushed
the
ruby_24_upgrade_webmock_to_231
branch
2 times, most recently
from
8ae1594 to
82cddc7
Compare
|
Re-recording should not be necessary. |
jrafanie
force-pushed
the
ruby_24_upgrade_webmock_to_231
branch
from
82cddc7 to
3b0423a
Compare
jrafanie
changed the title
[1] Older webmock is not compatible with ruby 2.4 [2] webmock 2+ needs VCR 3.0.2+ [2] [3] Script from [2] to convert userinfo in uri to auth header (in cassettes) [4] An alternative script [5] thanks to cben for digging into this [6] very similar to the change for foreman_api_client [1] Ruby 2.4.0 removed the closed? check in the conditional in: s.close if !s.closed? Webmock was changed to add close to StubSocket along with another change... ruby/ruby@f845a9e bblimke/webmock@8f2176a WebMock 2.3.1+ fixed the issue with ruby 2.4.0 by adding StubSocket#close. [2] vcr/vcr#570 (comment) [3] https://gist.github.com/glaszig/9170b1cf2186674faeead74a68606c5d [4] https://gist.github.com/ujh/594c99385b6cbe92e32b1bbfa8578a45 [5] ManageIQ/kubeclient#247 [6] ManageIQ/foreman_api_client#7
jrafanie
force-pushed
the
ruby_24_upgrade_webmock_to_231
branch
from
3b0423a to
f99b505
Compare
|
ok, this should now pass on ruby 2.3 or 2.4. I didn't need to re-record the cassettes as @cben said 👏 . The commit has all the details if you need to convert other provider cassettes for webmock 2+ for ruby 2.4 support cc @durandom @blomquisg. Before we merge here, I'd like confirmation from @durandom that the change to webmock/vcr here won't affect the pluggable providers and specifically their tests (if/when this is merged). |
|
Some comments on commit jrafanie@f99b505 spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher.yml
|
|
Checked commit jrafanie@f99b505 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
ovirt: ManageIQ/manageiq-providers-ovirt#28
hawkular: ManageIQ/manageiq-providers-hawkular#21
needed to be converted. The others work.
I'm getting a hang on running repetitive tasks agains a bunch of provider repos. Let's extract more...
|
to be clear, the above PRs will only work once this here is merged |
|
thanks @chrisarcand 👍 |
[1] Older webmock is not compatible with ruby 2.4
[2] webmock 2+ needs VCR 3.0.2+ [2]
[3] Script from [2] to convert userinfo in uri to auth header (in
cassettes)
[4] An alternative script
[5] thanks to cben for digging into this
[6] very similar to the change for foreman_api_client
[1] Ruby 2.4.0 removed the closed? check in the conditional in: s.close if
!s.closed?
Webmock was changed to add close to StubSocket along with another
change...
ruby/ruby@f845a9e
bblimke/webmock@8f2176a
WebMock 2.3.1+ fixed the issue with ruby 2.4.0 by adding
StubSocket#close.
[2] vcr/vcr#570 (comment)
[3] https://gist.github.com/glaszig/9170b1cf2186674faeead74a68606c5d, forked to my account in case the original is lost: https://gist.github.com/jrafanie/018a7024df387962a21ace09cc304665
[4] https://gist.github.com/ujh/594c99385b6cbe92e32b1bbfa8578a45
[5] ManageIQ/kubeclient#247
[6] ManageIQ/foreman_api_client#7