delete authentication in provider

app/controllers/api/authentications_controller.rb

@@ -1,4 +1,18 @@
 module Api
   class AuthenticationsController < BaseController
+    def delete_resource(type, id, _data = {})
+      auth = resource_search(id, type, collection_class(:authentications))
+      raise 'type not currently supported' unless auth.respond_to?(:delete_in_provider_queue)
+      task_id = auth.delete_in_provider_queue
+      action_result(true, "Deleting #{authentication_ident(auth)}", :task_id => task_id)
+    rescue => err
+      action_result(false, err.to_s)
+    end
+
+    private
+
+    def authentication_ident(auth)
+      "Authentication id:#{auth.id} name: '#{auth.name}'"
+    end
   end
 end

config/api.yml

@@ -233,7 +233,7 @@
     :options:
     - :collection
     - :subcollection
-    :verbs: *gpd
+    :verbs: *gp
     :klass: Authentication
     :collection_actions:
       :get:
@@ -249,9 +249,6 @@
       :post:
       - :name: delete
         :identifier: embedded_automation_manager_credentials_delete
-      :delete:
-      - :name: delete
-        :identifier: embedded_automation_manager_credentials_delete
     :subcollection_actions:
       :get:
       - :name: read

spec/requests/api/authentications_spec.rb

@@ -1,4 +1,8 @@
 RSpec.describe 'Authentications API' do
+  let(:provider) { FactoryGirl.create(:provider_ansible_tower) }
+  let(:auth) { FactoryGirl.create(:ansible_cloud_credential, :resource => provider) }
+  let(:auth_2) { FactoryGirl.create(:ansible_cloud_credential, :resource => provider) }
+
   describe 'GET/api/authentications' do
     it 'lists all the authentication configuration script bases with an appropriate role' do
       auth = FactoryGirl.create(:authentication)
@@ -51,66 +55,89 @@
 
   describe 'POST /api/authentications' do
     it 'will delete an authentication' do
-      auth = FactoryGirl.create(:authentication)
       api_basic_authorize collection_action_identifier(:authentications, :delete, :post)
 
       expected = {
-        'results' => [a_hash_including('success' => true)]
+        'results' => [
+          a_hash_including(
+            'success' => true,
+            'message' => a_string_including('Deleting Authentication'),
+            'task_id' => a_kind_of(Numeric)
+          )
+        ]
       }
-      expect do
-        run_post(authentications_url, :action => 'delete', :resources => [{ 'id' => auth.id }])
-      end.to change(Authentication, :count).by(-1)
+      run_post(authentications_url, :action => 'delete', :resources => [{ 'id' => auth.id }])
+
       expect(response.parsed_body).to include(expected)
       expect(response).to have_http_status(:ok)
     end
 
-    it 'will forbid deletion to an authentication without appropriate role' do
+    it 'verifies that the type is supported' do
+      api_basic_authorize collection_action_identifier(:authentications, :delete, :post)
       auth = FactoryGirl.create(:authentication)
-      api_basic_authorize
 
       run_post(authentications_url, :action => 'delete', :resources => [{ 'id' => auth.id }])
-      expect(response).to have_http_status(:forbidden)
+
+      expected = {
+        'results' => [
+          { 'success' => false, 'message' => 'type not currently supported' }
+        ]
+      }
+      expect(response).to have_http_status(:ok)
+      expect(response.parsed_body).to include(expected)
     end
-  end
 
-  describe 'POST /api/authentications/:id' do
-    it 'will delete an authentication' do
-      auth = FactoryGirl.create(:authentication)
-      api_basic_authorize action_identifier(:authentications, :delete, :resource_actions, :post)
+    it 'will delete multiple authentications' do
+      api_basic_authorize collection_action_identifier(:authentications, :delete, :post)
 
-      expect do
-        run_post(authentications_url(auth.id), :action => 'delete')
-      end.to change(Authentication, :count).by(-1)
-      expect(response.parsed_body).to include('success' => true)
+      expected = {
+        'results' => [
+          a_hash_including(
+            'success' => true,
+            'message' => a_string_including('Deleting Authentication'),
+            'task_id' => a_kind_of(Numeric)
+          ),
+          a_hash_including(
+            'success' => true,
+            'message' => a_string_including('Deleting Authentication'),
+            'task_id' => a_kind_of(Numeric)
+          )
+        ]
+      }
+      run_post(authentications_url, :action => 'delete', :resources => [{ 'id' => auth.id }, { 'id' => auth_2.id }])
+
+      expect(response.parsed_body).to include(expected)
       expect(response).to have_http_status(:ok)
     end
 
-    it 'will not delete an authentication without an appropriate role' do
+    it 'will forbid deletion to an authentication without appropriate role' do
       auth = FactoryGirl.create(:authentication)
       api_basic_authorize
 
-      run_post(authentications_url(auth.id), :action => 'delete')
-
+      run_post(authentications_url, :action => 'delete', :resources => [{ 'id' => auth.id }])
       expect(response).to have_http_status(:forbidden)
     end
   end
 
-  describe 'DELETE /api/authentications/:id' do
+  describe 'POST /api/authentications/:id' do
     it 'will delete an authentication' do
-      auth = FactoryGirl.create(:authentication)
-      api_basic_authorize action_identifier(:authentications, :delete, :resource_actions, :delete)
+      api_basic_authorize action_identifier(:authentications, :delete, :resource_actions, :post)
+
+      run_post(authentications_url(auth.id), :action => 'delete')
 
-      expect do
-        run_delete(authentications_url(auth.id))
-      end.to change(Authentication, :count).by(-1)
-      expect(response).to have_http_status(:no_content)
+      expected = {
+        'success' => true,
+        'message' => a_string_including('Deleting Authentication'),
+        'task_id' => a_kind_of(Numeric)
+      }
+      expect(response.parsed_body).to include(expected)
+      expect(response).to have_http_status(:ok)
     end
 
     it 'will not delete an authentication without an appropriate role' do
-      auth = FactoryGirl.create(:authentication)
       api_basic_authorize
 
-      run_delete(authentications_url(auth.id))
+      run_post(authentications_url(auth.id), :action => 'delete')
 
       expect(response).to have_http_status(:forbidden)
     end