Fixes tag control multi-value #14382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-m-u Let's get a test around this please. |
|
Checked commit d-m-u@e2a0f14 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Mar 27, 2017
Fixes tag control multi-value (cherry picked from commit b9de782) https://bugzilla.redhat.com/show_bug.cgi?id=1436223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop-downs have multi-select functionality as of ManageIQ/manageiq-ui-classic#114. This fixes an issue where tag control, which is sub-classed from the same base as drop-down, lacks the necessary method for multiple items on the same field.
Related to ManageIQ/manageiq-ui-classic#729