Remove the policy checking for request_host_vmotion_enabled. #14429
Conversation
There are events request_host_enable_vmotion and request_host_disable_vmotion defined in db/fixtures/miq_event_definitions.csv. But request_host_vmotion_enabled is not a defined event.
|
Checked commit lfu@62d0ffe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -487,7 +487,7 @@ def disable_vmotion | |||
| def vmotion_enabled? | |||
| msg = validate_vmotion_enabled? | |||
| if msg[:available] && respond_to?(:vim_vmotion_enabled?) | |||
| check_policy_prevent("request_host_vmotion_enabled", "vim_vmotion_enabled?") | |||
| vim_vmotion_enabled? | |||
There was a problem hiding this comment.
@lfu I think removing this check makes sense, but for a slightly different reason. This looks like it was a typo more than an intentional change in event name. However, I do not believe we should be doing the check here for vmotion_enabled?. This method should return if it is supported from the provider and we are doing the policy check if it is requested.
On a side note, these methods should be refactored to move into the VMware specific layer since they all require vim_* methods. Probably along the lines of how we do the raw_* methods for other provider methods.
|
@lfu is there a BZ? Can you please create if it doesn't exist? |
…on_enabled Remove the policy checking for request_host_vmotion_enabled. (cherry picked from commit 0d957ec) https://bugzilla.redhat.com/show_bug.cgi?id=1457924
|
Euwe backport details: |
…on_enabled Remove the policy checking for request_host_vmotion_enabled. (cherry picked from commit 0d957ec) https://bugzilla.redhat.com/show_bug.cgi?id=1460359
|
Fine backport details: |
There are events
request_host_enable_vmotionandrequest_host_disable_vmotiondefined in db/fixtures/miq_event_definitions.csv.But
request_host_vmotion_enabledis not a defined event.https://bugzilla.redhat.com/show_bug.cgi?id=1457917
@miq-bot assign @gmcculloug
@miq-bot add_label bug, control, darga/yes, euwe/yes