Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude chargeback lookup tables #14466

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

carbonin
Copy link
Member

An AR validation which was being enforced during seeding was preventing the global server from starting up with failing rows in the database.

This situation happens when the seeded rows get replicated up from a remote region and then the global appliance runs through seeding again.

https://bugzilla.redhat.com/show_bug.cgi?id=1435004

An AR validation which was being enforced during seeding was
preventing the global server from starting up with failing
rows in the database.

This situation happens when the seeded rows get replicated up from
a remote region and then the global appliance runs through seeding
again.

https://bugzilla.redhat.com/show_bug.cgi?id=1435004
@miq-bot
Copy link
Member

miq-bot commented Mar 22, 2017

Checked commit carbonin@259ab71 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is alright as we don't replicate Rates already, and these tables are just enums for Rates.

@carbonin, this is caused by seed clean-up I did few weeks ago. Sorry, and thanks for the fix!

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM
Can the replication tests be enhanced to test seeding?
I think it would just take:

  1. global region seed
  2. remote region seed
  3. replicate
  4. expect(global_region.seed).not_to raise_error

@bdunne bdunne merged commit 22efb09 into ManageIQ:master Mar 23, 2017
@bdunne bdunne added the euwe/no label Mar 23, 2017
@bdunne bdunne added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 23, 2017
@carbonin
Copy link
Member Author

So there are no more actual replication tests (tests that actually replicate the data).

We might be able to do something like seed with two different regions and make sure that doesn't blow up?
We would have to also consider the excluded tables, but that might do the job.

@carbonin carbonin deleted the exclude_seeded_chargeback_tables branch May 18, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants