Add retire_now to Embedded Ansible job. #14479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
Mar 23, 2017
| @@ -2,4 +2,8 @@ class ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job < ManageIQ::P | |||
| include ManageIQ::Providers::AnsibleTower::Shared::AutomationManager::Job | |||
|
|
|||
| require_nested :Status | |||
|
|
|||
| def retire_now(requester = nil) | |||
| finish_retirement | |||
There was a problem hiding this comment.
We should still be setting the retirement_requester as part of the retire_now logic: https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/retirement_mixin.rb#L121
retirement state machine.
tinaafitz
force-pushed
the
job_retire_now
branch
from
f57ce8e
to
47cb8b9
Compare
|
Checked commit tinaafitz@47cb8b9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use retire_now to mark the job as retired.
Set the Ansible Playbook provisioned Services service_resources resource of type ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job to retired with retire_now.
https://www.pivotaltracker.com/story/show/141719033