Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup shortcut YAML setting for Configuration Management #14506

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix startup shortcut YAML setting for Configuration Management #14506

merged 1 commit into from
Apr 24, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Mar 24, 2017 •
edited
Loading

This fix required MiqShortcut.seed to refresh startup settings

https://bugzilla.redhat.com/show_bug.cgi?id=1342537

Screen shot prior to code fix:
startup configuration management selection prior to code fix

Screen shot post to code fix:
startup configuration management selection post code fix

@GregP
Copy link
Contributor Author

GregP commented Mar 24, 2017

@h-kataria Please review.

@h-kataria
Copy link
Contributor

@GregP should it be Configuration / Management that's how it is in the navigation

@GregP GregP force-pushed the startup_opt_configuration_mgmnt branch from d21a49a to 646a21b Compare March 28, 2017 18:32
@GregP
Copy link
Contributor Author

GregP commented Mar 28, 2017

@h-kataria Code changed to match UI navigation. Please review at your convenience.

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commit GregP@646a21b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@h-kataria
Copy link
Contributor

looks good, @Fryguy @chessbyte please merge.

@h-kataria
Copy link
Contributor

@miq-bot add_label euwe/yes

@chessbyte chessbyte merged commit 25b1727 into ManageIQ:master Apr 24, 2017
@chessbyte chessbyte added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

since it's euwe/yes, adding fine/yes...

simaishi pushed a commit that referenced this pull request May 11, 2017
@chessbyte @simaishi
Merge pull request #14506 from GregP/startup_opt_configuration_mgmnt
a1a2687 
Fix startup shortcut YAML setting for Configuration Management
(cherry picked from commit 25b1727)

https://bugzilla.redhat.com/show_bug.cgi?id=1449396
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit a1a26871802b87e6796b2198c9e2ca64ca843535
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Mon Apr 24 15:24:50 2017 -0400

    Merge pull request #14506 from GregP/startup_opt_configuration_mgmnt
    
    Fix startup shortcut YAML setting for Configuration Management
    (cherry picked from commit 25b17270394de5150a25dd732e555a1e85dcb116)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449396

simaishi pushed a commit that referenced this pull request Jun 2, 2017
@chessbyte @simaishi
Merge pull request #14506 from GregP/startup_opt_configuration_mgmnt
a541236 
Fix startup shortcut YAML setting for Configuration Management
(cherry picked from commit 25b1727)

https://bugzilla.redhat.com/show_bug.cgi?id=1458337
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit a5412365f691fe2887469c328f9e50bec70fb3b3
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Mon Apr 24 15:24:50 2017 -0400

    Merge pull request #14506 from GregP/startup_opt_configuration_mgmnt
    
    Fix startup shortcut YAML setting for Configuration Management
    (cherry picked from commit 25b17270394de5150a25dd732e555a1e85dcb116)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug core euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GregP @h-kataria @miq-bot @simaishi @chessbyte