Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Volumes should honour tag visibility #14517

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Container Volumes should honour tag visibility #14517

merged 1 commit into from
Apr 24, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Mar 27, 2017 •
edited
Loading

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

@miq-bot add_label providers/containers, bug

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

@isimluk @gtanzillo Can you please review?

@isimluk
Copy link
Member

isimluk commented Mar 27, 2017

Is this worth adding also to MiqExpression::BASE_TABLES ?

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

Is this worth adding also to MiqExpression::BASE_TABLES ?

@isimluk Thanks, I added it regardless of this issue

isimluk
isimluk reviewed Mar 27, 2017
View reviewed changes
lib/miq_expression.rb
@@ -30,6 +30,7 @@ class MiqExpression
ContainerRoute
ContainerService
ContainerTemplate
PersistentVolume
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Persistent/Container/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well actually I believe we want here PersistentVolume and not ContainerVolume which is the base class and basing reports on it will include other unrelated records (pods volumes).

@chessbyte chessbyte requested a review from simon3z March 28, 2017 17:32
isimluk
isimluk approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM, but I would love to have extra set of eyes reviewing this.

@imtayadeway or @gtanzillo ?

simon3z
simon3z approved these changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@simon3z simon3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zakiva
Copy link
Contributor Author

zakiva commented Apr 18, 2017

@gtanzillo Can you please take a look?

@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2017

Checked commit zakiva@b9faf82 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

@moolitayer
Copy link

@miq-bot add_label fine/yes

@moolitayer
Copy link

@gtanzillo please review/merge

@gtanzillo gtanzillo added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@gtanzillo gtanzillo merged commit d9cc1fd into ManageIQ:master Apr 24, 2017
simaishi pushed a commit that referenced this pull request Apr 24, 2017
@gtanzillo @simaishi
Merge pull request #14517 from zakiva/fix_volumes_tag
521a761 
Container Volumes should honour tag visibility
(cherry picked from commit d9cc1fd)

https://bugzilla.redhat.com/show_bug.cgi?id=1445086
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 521a761cb2583eb5b2cf1627f27c524d94c8f95a
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Apr 24 16:30:20 2017 -0400

    Merge pull request #14517 from zakiva/fix_volumes_tag
    
    Container Volumes should honour tag visibility
    (cherry picked from commit d9cc1fd1c49a3aad898550a0609c21e2b9aa4dc8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

@simon3z simon3z simon3z approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug fine/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zakiva @isimluk @miq-bot @moolitayer @simaishi @simon3z @gtanzillo