Allow partial POST edits on miq policy REST #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolitayer
changed the title
|
@miq-bot add_label bug, api, control |
|
@dkorn can you please review? |
dkorn
approved these changes
Mar 27, 2017
| policy = resource_search(id, type, collection_class(:policies)) | ||
| begin | ||
| add_policies_content(data, policy) | ||
| add_policies_content(data, policy) if data["policy_contents"] |
|
@abellotti please review |
|
I think this is fine, could you add a test for editing a policy without those previously required attributes, maybe editing name or description ? Thanks. |
Fix https://bugzilla.redhat.com/show_bug.cgi?id=1435777 policies API (MiqPolicy) should allow partial POST edits e.g POST localhost:3000/api/policies/1000000000007 { "action": "edit", "description": "Desc bar" } In addition the current error message is wrong as it is about creation not edit: { "error": { "kind": "bad_request", "message": "Resource conditions_ids, policy_contents needs be specified for creating a new policies", "klass": "Api::BadRequestError" } }
|
Checked commit moolitayer@8cb8017 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@abellotti please review |
|
Thanks for adding the test, LGTM!! Is this for fix needed for 5.7 (fine release) too, I see the BZ for 5.8. |
|
We have no specific need for it in 5.7 (euwe?) ATM as we are not using this API outside yet. Thanks |
|
sorry my confusion, I see the ticket is 5.8. |
simaishi
pushed a commit
that referenced
this pull request
Mar 31, 2017
Allow partial POST edits on miq policy REST (cherry picked from commit 6872ded) https://bugzilla.redhat.com/show_bug.cgi?id=1435777
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://bugzilla.redhat.com/show_bug.cgi?id=1435777
policies API (MiqPolicy) should allow partial POTS edits
e.g
In addition the error message is wrong as it is about creation not edit: