Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving hosts in ansible playbook job #14522

Merged
merged 1 commit into from
Mar 27, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Mar 27, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1434939

Before the hosts were left out before saving to options[:provision_job_options], there was no way to find out actual hosts to create a job.

With the fix the hosts are saved to options[:provision_job_options]; they are excluded only when passing options to the provider to launch a job (Provider expects inventory option, not hosts).

@bzwei
Copy link
Contributor Author

bzwei commented Mar 27, 2017

@miq-bot add_label bug
@miq-bot add_label providers/ansible_tower
@miq-bot add_label services
@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2017

Checked commit bzwei@17ce7bc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@gmcculloug gmcculloug merged commit dd14af2 into ManageIQ:master Mar 27, 2017
@gmcculloug gmcculloug added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017
@bzwei bzwei deleted the set_hosts_to_job branch March 27, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants