Remove resources from service

[jntullo]

This API enhancement allows for the removal of resources from a service as a follow up to the add resources enhancement.

Remove resources can be done from the collection:

POST /api/services
{
    'action'    => 'remove_resource',
    'resources' => [
          { 'href' => 'api/services/:id','resource' => { 'href' => 'api/vms/:id' },
          { 'href' => 'api/services/:id, 'resource' => { 'href' => 'api/vms/:id'} }
        ]
}

or from the resource:

POST /api/services/:id
{
    'action'   => 'remove_resource',
    'resource' => { 'resource' => {'href' => 'api/vms/:id' }}
}

cc: @mkanoor
@miq-bot add_label enhancement, api
@miq-bot assign @abellotti

[miq-bot]

Checked commit jntullo@3f4a286 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

[abellotti]

Thanks @jntullo for this enhancement, this LGTM!! 😍 will merge when 🍏

[abellotti]

@jntullo and @mkanoor is this master only or needed in Fine-release ?

[mkanoor]

@abellotti @gmcculloug @jntullo
Since we are in alpha can't be add it to the Fine release?

[gmcculloug]

Checking with @jonnyfiveiq to confirm if we can include in the fine release.

[chriskacerguis]

@gmcculloug SUI does need this for Fine.

[gmcculloug]

@chriskacerguis Is there a bug, issue or story we can link this to?

[chriskacerguis]

@gmcculloug sure (sorry for not including it). Here's the PT that needs it: https://www.pivotaltracker.com/story/show/142775095

[gmcculloug]

😕 I am not sure how these two things are related. The pivotal story is for "Retire now" and this PR is for removing resources, like VMs, from a service.

[chriskacerguis]

@gmcculloug the "retire now" is exactly that; we need to remove a resource (such as a VM) from a service.

[simaishi]

Fine backport details:

$ git log -1
commit f9a5bb0f01284d4c8918862e441e8009ae261cda
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Mon Apr 3 15:48:12 2017 -0400

    Merge pull request #14581 from jntullo/enhancement/remove_resources
    
    Remove resources from service
    (cherry picked from commit 88669e4fae2e6f612a4d58983d0aa17e1a0f8c3e)