Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Physical Infra Topology feature #14589

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Add Physical Infra Topology feature #14589

merged 1 commit into from
Apr 3, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Mar 30, 2017 •
edited
Loading

Adds the product feature id required for the Physical Infrastructure Topology menu.

screen shot 2017-03-30 at 5 12 52 pm

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commit AparnaKarve@eb699dc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

This was referenced Mar 31, 2017
Merged
Merged
@abellotti
Copy link
Member

abellotti commented Mar 31, 2017 •
edited
Loading

Not my Forte, but I think this is good. /cc @h-kataria ?

@martinpovolny martinpovolny merged commit 7d24994 into ManageIQ:master Apr 3, 2017
@martinpovolny martinpovolny added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 3, 2017
@martinpovolny
Copy link
Member

Fine?

@abellotti
Copy link
Member

/cc @AparnaKarve @h-kataria is this needed for Fine release ?

@himdel
Copy link
Contributor

himdel commented Apr 5, 2017

Added fine/yes because PHinfra topology is broken without this and dependencies..

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Apr 5, 2017
@martinpovolny @simaishi
Merge pull request #14589 from AparnaKarve/add_physical_infra_topolog…
3160779 
…y_feature

Add Physical Infra Topology feature
(cherry picked from commit 7d24994)
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2017

Fine backport details:

$ git log -1
commit 316077988289113e7c89db17497eceeab521866d
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Apr 3 11:20:55 2017 +0200

    Merge pull request #14589 from AparnaKarve/add_physical_infra_topology_feature
    
    Add Physical Infra Topology feature
    (cherry picked from commit 7d24994769f0ae94128890861403ad637cdceef3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
core/rbac enhancement fine/backported providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AparnaKarve @miq-bot @abellotti @martinpovolny @himdel @simaishi @chessbyte