Ensure remote shells generated by SCVMM are closed when finished #14591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WinRM shells being created for SCVMM are not being closed properly. It seems we did not completely update the code for WinRM 2.x completely when we upgraded. The result is that sometimes the server will refuse the connection until some of the existing shells eventually time out. This fixes that by ensuring a shell is closed once finished.
It also takes advantage of the stdout and stderr methods, and removes an unnecessary variable assignment.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1436180
Replaces #13637