[EUWE] Tenancy for CloudTenant #14593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these methods are taken from TenancyMixin and changed to usage for cloud tenancy for generating proper queries for RBAC calls
lpichler
changed the title
|
Checked commits lpichler/manageiq@5186274~...a7e3c2b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is allowing tenancy RBAC feature for CloudTenant objects when cloud tenant mapping is used
pulled out from Introduces CloudTenancyMixin to fix RBAC for cloud_tenant based models #13535 and Enable cloud_tenant based RBAC for additional models #14036 but only functionality for CloudTenant as is need in the BZ
I am not creating new mixin for it but just I am adding needed methods to CloudTenant model
and then I using them in RBac similarly as is done in origin tenancny
@miq-bot add_label core, euwe/yes, blocker, enhancement
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1433069
please review @gtanzillo @rwsu
@miq-bot assign @simaishi