-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container image post refresh from openshift #14628
Container image post refresh from openshift #14628
Conversation
cc @bazulay @simon3z @agrare @cben
Please advise on both. I will start working on the second point but would like your input. |
8d0e1fc
to
d592de7
Compare
ebc927a
to
4ab902a
Compare
Added |
4ab902a
to
d51d42a
Compare
This pull request is not mergeable. Please rebase and repush. |
d51d42a
to
bf3d4ee
Compare
ed9f9f0
to
ef398d0
Compare
ef398d0
to
edc0e72
Compare
EmsRefresh.save_labels_inventory(self, | ||
openshift_image_data.delete(:labels)) | ||
EmsRefresh.save_docker_labels_inventory(self, | ||
openshift_image_data.delete(:docker_labels)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cben I changed here to use "save_inventory" functions in accordance to our discussion about this. PTAL
edc0e72
to
bc6a105
Compare
Checked commits enoodle/manageiq@059bf79~...bc6a105 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This pull request is not mergeable. Please rebase and repush. |
@simon3z rebase and repush? |
@simon3z @chessbyte IIUC this kind of solution is less relevant with the graph refresh on its way to us. |
For the record, we saw fetching just a single image metadata with |
This will enable container images to grab information from openshift (
refresh_openshift_information
) and will hook this in the queue for each new image after the refresh. This makes sense after #14606 when skiping openshift image refresh.