Drop 'jobs.agent_id' column. #14634
Merged
Drop 'jobs.agent_id' column. #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
changed the title
miq-bot
changed the title
yrudman
changed the title
yrudman
changed the title
yrudman
force-pushed
the
drop-agent_id_column-from-jobs
branch
2 times, most recently
from
709eee4
to
d598c7e
Compare
yrudman
changed the title
|
@miq-bot add-label fine/no |
|
This pull request is not mergeable. Please rebase and repush. |
Fryguy
approved these changes
May 9, 2017
yrudman
force-pushed
the
drop-agent_id_column-from-jobs
branch
from
d598c7e
to
9144263
Compare
yrudman
force-pushed
the
drop-agent_id_column-from-jobs
branch
from
b6345c5
to
f982628
Compare
…b#agent_id' were removed in ManageIQ#14030
yrudman
force-pushed
the
drop-agent_id_column-from-jobs
branch
from
f982628
to
404f3e8
Compare
|
Checked commit yrudman@404f3e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Fryguy it is mergeable now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked:
Jobmodel Refactor/clean up 'agent' related logic onJobmodel #14030All references to 'jobs.agent_id' were removed in #14030, and this column not in use.
Dropping it will make future merging of
JobandMiqTaskmodels simpler.@miq-bot add-label core, technical debt, wip