-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter embedded ansible for rpm builds #14637
Alter embedded ansible for rpm builds #14637
Conversation
This wrapper script is provided in /usr/bin by the rpm rather than installed in a path by us manually.
This extra variable tells the setup script that it shouldn't attempt to set up the various files needed to run the tower UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Checked commits carbonin/manageiq@9984f38~...e47eafb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
installed_rpms = { | ||
"ansible-tower-server" => "1.0.1", | ||
"ansible-tower-setup" => "1.2.3", | ||
"vim" => "13.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, vim
Looks good to me! 😎 👍 |
…m_builds Alter embedded ansible for rpm builds (cherry picked from commit cb39482)
Fine backport details:
|
This PR allows our Embedded Ansible role to work with the new RPM installed packages.
We move away from checking for the setup script in
/opt/ansible-installer
and use the files provided for us by the RPM.This PR also includes changes to account for the UI not being present when the setup script is run.