Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklisted event names in settings.yml #14647

Merged
merged 2 commits into from
May 9, 2017

Conversation

durandom
Copy link
Member

@durandom durandom commented Apr 5, 2017

default blacklisted event names are now sourced from settings.yml

this allows providers just provide a setting in

 :ems:
   :ems_<%= provider_name %>:
     :blacklisted_event_names: []

I moved the method to BaseManager, because I think it belongs there and BaseManager has the provider inflection methods (to get the provider name via provider_name)

In a follow up PR, we can remove the method in the subclasses and just add the events to settings.yml in the provider repo.

ps. I just realised there is ExtManagementSystem.short_token, which arguably could also be used. I'll replace this method later with the inflection methods.

cc @agrare @bronaghs @blomquisg

@Fryguy please review

@durandom
Copy link
Member Author

durandom commented Apr 5, 2017

@miq-bot assign @Fryguy
@miq-bot add_labels enhancement, pluggable providers

this allows providers just provide a setting in
:ems -> :ems_<provider_name> -> :blacklisted_event_names
@miq-bot
Copy link
Member

miq-bot commented Apr 5, 2017

Checked commits durandom/manageiq@2c24c3a~...7b2bd75 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🏆

@agrare
Copy link
Member

agrare commented Apr 5, 2017

This looks great, we can get rid of the hard-coded default events while still allowing new blacklisted events to be added per provider-type or per provider by adding them to the db.

@durandom
Copy link
Member Author

durandom commented May 9, 2017

@Fryguy is this good to go?

@Fryguy Fryguy merged commit 82637f6 into ManageIQ:master May 9, 2017
@Fryguy Fryguy added this to the Sprint 61 Ending May 22, 2017 milestone May 9, 2017
@durandom durandom deleted the blacklisted_event_names branch May 9, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants