blacklisted event names in settings.yml #14647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default blacklisted event names are now sourced from
settings.yml
this allows providers just provide a setting in
I moved the method to
BaseManager
, because I think it belongs there andBaseManager
has the provider inflection methods (to get the provider name viaprovider_name
)In a follow up PR, we can remove the method in the subclasses and just add the events to settings.yml in the provider repo.
ps. I just realised there is
ExtManagementSystem.short_token
, which arguably could also be used. I'll replace this method later with the inflection methods.cc @agrare @bronaghs @blomquisg
@Fryguy please review