Charge since the first MetricRollup #14666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
reviewed
Apr 7, 2017
app/models/chargeback/consumption.rb
Outdated
| if born_at && born_at > @start_time | ||
| # run this extra SELECT only when useful -- if resource was born in the current interval | ||
| # metrics can be older than resource (first capture may go few days back) | ||
| born_at = [born_at, resource.first_capture].compact.min |
There was a problem hiding this comment.
@isimluk can we somehow reuse first_metric_rollup_record what we already have (instead of first_capture) ?
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1433984 On a fresh install, we start with inventory collection at time X. The resources are then created_on time X. However, the C&U collection can go few day back (by default we go back to beginning_of_day, but this is subject to configuration. (See Settings.performance.history.initial_capture_days) When charging, we cannot rely on created_on time, we can charge from the beginning of the C&U for the given resource.
|
Checked commits isimluk/manageiq@cc3f6c1~...cf82d67 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
Charge since the first MetricRollup (cherry picked from commit e43ccab) https://bugzilla.redhat.com/show_bug.cgi?id=1441244
|
Fine backport details: |
|
@isimluk @gtanzillo backporting this to Euwe branch is requested on the BZ. Would that be a problem? |
|
@simaishi I don't see any problem with backporting this to Euwe. |
simaishi
pushed a commit
that referenced
this pull request
Jun 30, 2017
Charge since the first MetricRollup (cherry picked from commit e43ccab) https://bugzilla.redhat.com/show_bug.cgi?id=1465077
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1433984
On a fresh install, we start with inventory collection at time X. The resources are then created_on time X. However, the C&U collection can go few day back (by default we go back to
beginning_of_day, but this issubject to configuration. (See
Settings.performance.history.initial_capture_days)When charging, we cannot rely on created_on time, we can charge from the beginning of the C&U for the given resource.