Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure job is refreshed in the condition of state machine exits on error #14684

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Ensure job is refreshed in the condition of state machine exits on error #14684

merged 2 commits into from
Apr 7, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Apr 6, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1439667

We want to refresh the job status and time stamps one final time at the error condition.

Also fix a coding error in postprocess. The old coincidentally correctly cleaned up the temporary inventory.

@bzwei
Copy link
Contributor Author

bzwei commented Apr 6, 2017

@miq-bot add_label bug, providers/ansible_tower, services, fine/yes
@miq-bot assign @gmcculloug
cc @tinaafitz

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

Checked commits bzwei/manageiq@e6de791~...48fb1a2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@tinaafitz
Copy link
Member

@bzwei Looks good.

@gmcculloug
Copy link
Member

👍 @bdunne Any comments here?

@bdunne bdunne merged commit 3579c51 into ManageIQ:master Apr 7, 2017
@bdunne bdunne added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 7, 2017
@bzwei bzwei deleted the ensure_refresh branch April 7, 2017 17:45
simaishi pushed a commit that referenced this pull request Apr 7, 2017
@bdunne @simaishi
Merge pull request #14684 from bzwei/ensure_refresh
2444804 
Ensure job is refreshed in the condition of state machine exits on error
(cherry picked from commit 3579c51)

https://bugzilla.redhat.com/show_bug.cgi?id=1440323
@simaishi
Copy link
Contributor

simaishi commented Apr 7, 2017

Fine backport details:

$ git log -1
commit 24448046b13741f0200c89a3c80c25eb40c6a230
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Fri Apr 7 12:01:12 2017 -0400

    Merge pull request #14684 from bzwei/ensure_refresh
    
    Ensure job is refreshed in the condition of state machine exits on error
    (cherry picked from commit 3579c5110319dfeada4c4604e962b806ad31ae79)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1440323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug fine/backported lifecycle/services providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bzwei @miq-bot @tinaafitz @gmcculloug @simaishi @bdunne @Fryguy