Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name and description not getting updated #14689

Merged
merged 2 commits into from
Apr 7, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Apr 7, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1440226

In the Namespace object the display name and description
attributes were not getting updated.

Links

Steps for Testing/QA [Optional]

In Bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1440226

In the Namespace object the display name and description
attributes were not getting updated.
@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commits mkanoor/manageiq@e9681bb~...b08f1f6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@gmcculloug
Copy link
Member

@mkanoor Can you set the DisplayName for a Namespace somewhere other then modifying the export by hand?

image

I am ok with it being included here for completeness, but wondering how it would get set.

@tinaafitz
Copy link
Member

@mkanoor Looks good.

@gmcculloug
Copy link
Member

So here's what is going on:

  1. The Display Name field is not editable from the UI for Namespaces, but it does appear in the tree-view.
  2. Description is editable, but does not show in the UI anywhere. I'm thinking it should be a column in the list-view for namespaces/classes.

image

@mkanoor Please open two git issues in the UI repo to address these issues.

@mkanoor
Copy link
Contributor Author

mkanoor commented Apr 7, 2017

@gmcculloug I think the UI should be able to display the details of the namespace but not allow users to change them if its a locked domain.

@gmcculloug
Copy link
Member

Correct, I am not referring to the ManageIQ domain and namespace you are updating here, it just exposed the issue.

This is a generic issue for any unlocked Domain. Locked domains should not allow the user to modify them, as we do today.

@gmcculloug gmcculloug merged commit e542416 into ManageIQ:master Apr 7, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 7, 2017
simaishi pushed a commit that referenced this pull request Apr 7, 2017
Display name and description not getting updated
(cherry picked from commit e542416)
@simaishi
Copy link
Contributor

simaishi commented Apr 7, 2017

Fine backport details:

$ git log -1
commit ef84e99fe78067e92b7c5f2ed327291136c178ed
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Apr 7 14:39:45 2017 -0400

    Merge pull request #14689 from mkanoor/update_ns_attributes
    
    Display name and description not getting updated
    (cherry picked from commit e542416d79e5c60e3b8216f2df3674ba48856d6c)

simaishi pushed a commit that referenced this pull request Apr 17, 2017
Display name and description not getting updated
(cherry picked from commit e542416)

https://bugzilla.redhat.com/show_bug.cgi?id=1442865
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 7aa92d4ddf135919df9fb11b732db770d4af01ef
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Apr 7 14:39:45 2017 -0400

    Merge pull request #14689 from mkanoor/update_ns_attributes
    
    Display name and description not getting updated
    (cherry picked from commit e542416d79e5c60e3b8216f2df3674ba48856d6c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants