Do not pass nil to the assignment mixin #14713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing: [NoMethodError]: undefined method `base_model' for NilClass:Class Method:[rescue in _async_generate_table] app/models/mixins/assignment_mixin.rb:146:in `block in get_assigned_for_target' app/models/mixins/assignment_mixin.rb:146:in `collect' app/models/mixins/assignment_mixin.rb:146:in `get_assigned_for_target' app/models/chargeback/rates_cache.rb:13:in `rates' app/models/chargeback/rates_cache.rb:7:in `get' app/models/chargeback.rb:9:in `block in build_results_for_report_chargeback' app/models/chargeback/consumption_history.rb:31:in `block (2 levels) in for_report' Introduced in 31fac86 Lesson learned: when you see two lists with [].compact, it is usually good idea to use compact too. If we merged ManageIQ#14090 we wouldn't see this at customer.
|
Checked commit isimluk@36222c1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lpichler
approved these changes
Apr 10, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
Do not pass nil to the assignment mixin (cherry picked from commit 17e9829) https://bugzilla.redhat.com/show_bug.cgi?id=1441199
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
Do not pass nil to the assignment mixin (cherry picked from commit 17e9829) https://bugzilla.redhat.com/show_bug.cgi?id=1441198
|
Fine backport details: |
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
Do not pass nil to the assignment mixin (cherry picked from commit 17e9829) https://bugzilla.redhat.com/show_bug.cgi?id=1441199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ
https://bugzilla.redhat.com/show_bug.cgi?id=1440917
Addressing
Introduced in 31fac86
Lesson learned: when you see two lists with
[].compactabove your edit, it is usually good idea to consider using.compacttoo.If we merged #14090 we wouldn't see this at customer. 😑 ❗️