Additional tests for queueing of collection of historical metrics #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit gtanzillo@e95be2e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/metric/ci_mixin/capture_spec.rb
|
gtanzillo
commented
Apr 11, 2017
| @@ -86,6 +86,8 @@ def verify_perf_capture_queue(last_perf_capture_on, total_queue_items) | |||
| Timecop.freeze do | |||
| Timecop.travel(Time.now.end_of_day - 6.hours) | |||
| verify_perf_capture_queue(nil, 1) | |||
| Timecop.travel(Time.now + 20.minutes) | |||
| verify_perf_capture_queue(nil, 1) | |||
There was a problem hiding this comment.
I added this so that it tests that no additional messages are added to the queue calling realtime a second time when last_perf_capture_on ids nil.
simaishi
pushed a commit
that referenced
this pull request
Apr 13, 2017
Additional tests for queueing of collection of historical metrics (cherry picked from commit 6db53a9)
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 17, 2017
Additional tests for queueing of collection of historical metrics (cherry picked from commit 6db53a9)
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #14695.
This adds verification that calling
perf_capture_queue("historical")will create the correct number of queue messages and will not queue additional messages when called multiple times.