Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link MiqTemplates to their parent VM when one is present #14755

Merged
merged 2 commits into from
Apr 17, 2017

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Apr 12, 2017

Some MiqTemplates (like Openstack images) have parent VMs. This PR updates vm_and_miq_template_ancestry to resolve those VM->Template relationships as well as the already existing Template->VM relationships.

@mansam
Copy link
Contributor Author

mansam commented Apr 12, 2017

@Ladas @tzumainn

@Ladas
Copy link
Contributor

Ladas commented Apr 13, 2017

@mansam could you run 'bundle exec rubocop -a ' ? Just to keep things aligned, push it as a separate commit.

@Ladas
Copy link
Contributor

Ladas commented Apr 13, 2017

awesome work 👍

@Ladas
Copy link
Contributor

Ladas commented Apr 13, 2017

@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commits mansam/manageiq@aacba30~...7b8c06c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@agrare agrare merged commit 681583e into ManageIQ:master Apr 17, 2017
@agrare agrare added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants