Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate - added vmware reconfigure model to quota helper. #14756

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

calculate_requested_spec method now requires this.

see ManageIQ/manageiq-content#56

@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label automate

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please Review

calculate_requested_spec method now requires this.
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commit billfitzgerald0120@9c40867 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@tinaafitz
Copy link
Member

@billfitzgerald0120 looks good.
@mkanoor Please review.

Copy link
Contributor

@mkanoor mkanoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using local variables instead of the instance variables. Maybe that cleanup can be done in a different PR

@mkanoor mkanoor merged commit da6b7d7 into ManageIQ:master Apr 17, 2017
@mkanoor mkanoor added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 17, 2017
simaishi pushed a commit that referenced this pull request Jun 6, 2017
Automate - added vmware reconfigure model to quota helper.
(cherry picked from commit da6b7d7)
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Required by ManageIQ/manageiq-content#56

Fine backport details:

$ git log -1
commit 4a9232331b687ff48a9ad6eb0c830fb571c62080
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Mon Apr 17 14:56:27 2017 -0400

    Merge pull request #14756 from billfitzgerald0120/quota_helper_spec
    
    Automate - added vmware reconfigure model to quota helper.
    (cherry picked from commit da6b7d7b0b9dff423f320b90fc5959b4dc90dabf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants