-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate - added vmware reconfigure model to quota helper. #14756
Conversation
@miq-bot add_label automate |
@tinaafitz |
9398ffa
to
dab52d0
Compare
calculate_requested_spec method now requires this.
dab52d0
to
9c40867
Compare
Checked commit billfitzgerald0120@9c40867 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@billfitzgerald0120 looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer using local variables instead of the instance variables. Maybe that cleanup can be done in a different PR
Automate - added vmware reconfigure model to quota helper. (cherry picked from commit da6b7d7)
Required by ManageIQ/manageiq-content#56 Fine backport details:
|
calculate_requested_spec method now requires this.
see ManageIQ/manageiq-content#56