Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default filters for the container page #14893

Merged
merged 1 commit into from
May 11, 2017
Merged

Add default filters for the container page #14893

merged 1 commit into from
May 11, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Apr 26, 2017 •
edited
Loading

Description

Currently the containers explorer page (https:///container/explorer) crashes when there is a large number of containers (e.g. ~4000).

Add some default filters to the Container page, make the filtering more useful, after removing the tree.

PR in UI Classic: ManageIQ/manageiq-ui-classic#1204
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1443743

Screenshots

screenshot-localhost 3000-2017-04-26-12-03-22

screenshot-localhost 3000-2017-04-26-12-04-22

@yaacov
Copy link
Member Author

yaacov commented Apr 26, 2017

@miq-bot add_label providers/containers, bug

@simon3z @dkorn @moolitayer @himdel @dclarizio please review

@yaacov
Copy link
Member Author

yaacov commented Apr 26, 2017

@cben please review

@yaacov yaacov mentioned this pull request Apr 26, 2017
Closed
moolitayer
moolitayer reviewed Apr 27, 2017
View reviewed changes
db/fixtures/miq_searches.yml Outdated
@@ -1275,3 +1275,33 @@
value: analysis_success
search_type: default
db: ManageIQ::Providers::InfraManager::Vm
- attributes:
name: State / Running
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do all the names in this file start with default_?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a. It's just a name ... as far at I searched, no one use it, so you can write whatever you want here.
b. I will fix it for style :-)

@moolitayer fixing now 👍

@moolitayer
Copy link

@yaacov can you now select filters from here to be selected by default? (in "My Setting")

@moolitayer
Copy link

@yaacov can you now select filters from here to be selected by default? (in My Setting)

@yaacov
Copy link
Member Author

yaacov commented Apr 27, 2017

@yaacov can you now select filters from here to be selected by default? (in My Setting)

a. Yes, I can select filters from here in My Setting, to be shown as options.
b. No, they can not be selected by default. I do not think, you can do that from My Settings for any filter.

screenshot-localhost 3000-2017-04-27-17-28-13

@yaacov yaacov force-pushed the do-not-show-containers-tree branch from f4f96df to 36a4b69 Compare April 27, 2017 14:38
@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit yaacov@36a4b69 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

moolitayer
moolitayer approved these changes Apr 27, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simon3z
Copy link
Contributor

simon3z commented Apr 28, 2017

LGTM 👍
@miq-bot assign blomquisg
cc @blomquisg @chessbyte

@miq-bot miq-bot assigned blomquisg and unassigned simon3z Apr 28, 2017
@blomquisg blomquisg assigned dclarizio and unassigned blomquisg May 4, 2017
@dclarizio
Copy link

This looks fine to me . . . @blomquisg good to merge afaic.

@yaacov yaacov mentioned this pull request May 10, 2017
Merged
@yaacov
Copy link
Member Author

yaacov commented May 10, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1443743
Target is 5.8.1

@miq-bot add_label fine/yes

@yaacov
Copy link
Member Author

yaacov commented May 11, 2017

@dclarizio @blomquisg merge ?

@yaacov
Copy link
Member Author

yaacov commented May 11, 2017 •
edited
Loading

ManageIQ/manageiq-ui-classic#1204 merged , without this PR it will show "No filters defined" message, on the navlist bar.

f41d8104-3586-11e7-9995-29dc33625526

@dclarizio
Copy link

@blomquisg you have the green button

@chessbyte chessbyte assigned chessbyte and unassigned dclarizio May 11, 2017
@chessbyte chessbyte merged commit c1d66c8 into ManageIQ:master May 11, 2017
@chessbyte chessbyte added this to the Sprint 61 Ending May 22, 2017 milestone May 11, 2017
simaishi pushed a commit that referenced this pull request Jun 5, 2017
@chessbyte @simaishi
Merge pull request #14893 from yaacov/do-not-show-containers-tree
1332fb9 
Add default filters for the container page
(cherry picked from commit c1d66c8)

https://bugzilla.redhat.com/show_bug.cgi?id=1458934
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit 1332fb90715b8e98d599f3c43fcfa9749b5470dc
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Thu May 11 17:58:28 2017 -0400

    Merge pull request #14893 from yaacov/do-not-show-containers-tree
    
    Add default filters for the container page
    (cherry picked from commit c1d66c8ff4a31cdd07c047278ae4a20a537e65bf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon3z simon3z simon3z approved these changes

@moolitayer moolitayer moolitayer approved these changes

Assignees

@chessbyte chessbyte

Labels
bug fine/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yaacov @moolitayer @miq-bot @simon3z @dclarizio @simaishi @blomquisg @chessbyte