Cache node_types instead of calling on every request #14922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
changed the title
|
/cc @jrafanie I updated comment to show true motivation |
We currently query the database 2-4 queries on every request to determine if we have an open stack provider to display openstack labels in the menu.
|
Checked commit kbrock@2a27c11 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
reviewed
Jun 2, 2017
| :mixed_clusters | ||
| else | ||
| :openstack | ||
| end |
There was a problem hiding this comment.
I'm ok with this but it still feels like this is wrong. We should have cross cloud terminology, a combination of all the things, or a place for them to choose the wording. The fact that we query the database, have lots of backend and UI code to try to figure out what to call things in the UI amazes me. cc @chessbyte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Hosts and Clusters, we display different text for customers who have open stack and those who do not.
We query the database 2-4 queries on every request for this label in the menu.
A typical lean screen has 17 queries.
So 2-4 queries is (11% - 25% by quantity). But these are fast, so % of time is small.
But to be honest, this is more of a frustration PR.
I'm working very hard to delete queries, and these are queries that are run on every page and seem like it should just be a
settings.ymlflag.Options:
settings.yaml.