Remove the Eventcatcher from CinderManager #14962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roliveri Please review. |
jerryk55
suggested changes
May 2, 2017
| @@ -2,8 +2,6 @@ | |||
| # | |||
|
|
|||
| class ManageIQ::Providers::StorageManager::CinderManager < ManageIQ::Providers::StorageManager | |||
| require_nested :EventCatcher | |||
| require_nested :EventParser | |||
| require_nested :RefreshParser | |||
| require_nested :RefreshWorker | |||
| require_nested :Refresher | |||
There was a problem hiding this comment.
@hsong-rh - shouldn't the event_monitor_class at the end of this file be removed as well? (as well as the one from the swift_manager.rb - not sure why I added that)
There was a problem hiding this comment.
Yes, changed to remove it.
blomquisg
suggested changes
May 4, 2017
roliveri
suggested changes
May 4, 2017
|
@hsong-rh bump |
|
This pull request is not mergeable. Please rebase and repush. |
hsong-rh
force-pushed
the
remove_cindermanager_eventcatcher
branch
from
d5a3b74
to
dfbd06b
Compare
|
@roliveri @blomquisg Made the change according to Jerry's comments. Please review again, thanks. |
roliveri
approved these changes
Aug 17, 2017
|
This pull request is not mergeable. Please rebase and repush. |
hsong-rh
force-pushed
the
remove_cindermanager_eventcatcher
branch
from
dfbd06b
to
772bdc2
Compare
|
Checked commit hsong-rh@772bdc2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
approved these changes
Aug 18, 2017
juliancheal
pushed a commit
to juliancheal/manageiq-schema
that referenced
this pull request
Jan 8, 2019
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1661957 Cinder Event Catcher was removed in ManageIQ/manageiq#14962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no specific events need to be catch for cinder storage manager. Remove it from CinderManager and event catcher list.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1465395
#14961